jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/673698 ) Change subject: [fix] Do not use len() to determine if a sequence is empty ...................................................................... [fix] Do not use len() to determine if a sequence is empty Change-Id: I797fcb86f09797acbf0158fd465c07b611b75be8 --- M pywikibot/page/__init__.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 233113f..38eb623 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -2254,7 +2254,7 @@ @return: instance of FileInfo() """ - if not len(self._file_revisions): + if not self._file_revisions: self.site.loadimageinfo(self, history=True) latest_ts = max(self._file_revisions) return self._file_revisions[latest_ts] @@ -2269,7 +2269,7 @@ @return: instance of FileInfo() """ - if not len(self._file_revisions): + if not self._file_revisions: self.site.loadimageinfo(self, history=True) oldest_ts = min(self._file_revisions) return self._file_revisions[oldest_ts] @@ -2282,7 +2282,7 @@ key: timestamp of the entry value: instance of FileInfo() """ - if not len(self._file_revisions): + if not self._file_revisions: self.site.loadimageinfo(self, history=True) return self._file_revisions -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/673698 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I797fcb86f09797acbf0158fd465c07b611b75be8 Gerrit-Change-Number: 673698 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged