jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/569101 )

Change subject: [bugfix] Fix parameters in OauthLoginManager() ......................................................................

[bugfix] Fix parameters in OauthLoginManager()

Fix parameters when calling OauthLoginManager(), after removal of sysop parameter.

Change-Id: I56ede124fe2f6f3add26a315f22b127cd34e66a2 --- M scripts/login.py M tests/oauth_tests.py 2 files changed, 2 insertions(+), 3 deletions(-)

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified

diff --git a/scripts/login.py b/scripts/login.py index cfabfb6..e90f814 100755 --- a/scripts/login.py +++ b/scripts/login.py @@ -80,8 +80,7 @@

def _oauth_login(site): consumer_key, consumer_secret = _get_consumer_token(site) - login_manager = OauthLoginManager(consumer_secret, False, site, - consumer_key) + login_manager = OauthLoginManager(consumer_secret, site, consumer_key) login_manager.login() identity = login_manager.identity if identity is None: diff --git a/tests/oauth_tests.py b/tests/oauth_tests.py index cc44abd..00cbdee 100644 --- a/tests/oauth_tests.py +++ b/tests/oauth_tests.py @@ -79,7 +79,7 @@ self.assertIsNotNone(login_manager.access_token) self.assertIsInstance(login_manager.identity, dict) self.assertEqual(login_manager.identity['username'], - self.site.username(sysop=False)) + self.site.username())

if __name__ == '__main__': # pragma: no cover