jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404435 )

Change subject: [doc] Update breaking change info for getVersionHistory ......................................................................

[doc] Update breaking change info for getVersionHistory

- There is a difference in timestamp too - Update compat2core.py script accordingly

Bug: T136513 Change-Id: Ibd89306199ee346369d9241a78f61b94fcc3b9f3 --- M pywikibot/page/__init__.py M scripts/maintenance/compat2core.py 2 files changed, 5 insertions(+), 2 deletions(-)

Approvals: Dvorapa: Looks good to me, but someone else must approve Huji: Looks good to me, approved jenkins-bot: Verified

diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index a1a92b5..a8b435c 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -1768,6 +1768,8 @@ # (revid, timestamp, user, comment) # whereas old framework had a tuple of 6 items: # (revid, timestamp, user, comment, size, tags) + # + # timestamp is a pywikibot.Timestamp, not a MediaWiki timestamp string @deprecated('Page.revisions()', since='20150206') @deprecated_args(forceReload=None, revCount='total', step=None, getAll=None, reverseOrder='reverse') diff --git a/scripts/maintenance/compat2core.py b/scripts/maintenance/compat2core.py index 29b3129..2d4d558 100755 --- a/scripts/maintenance/compat2core.py +++ b/scripts/maintenance/compat2core.py @@ -98,8 +98,9 @@ ('.replaceImage(', 'Page.replaceImage() is deprecated and does not work at core'), ('.getVersionHistory(', - 'Page.getVersionHistory() returns a pywikibot.Timestamp object instead of' - '\na MediaWiki one'), + 'Page.getVersionHistory() returns a pywikibot.Timestamp object instead\n' + 'of a MediaWiki one. It also returns a tuple of 4 items instead of 6:\n' + 'size and tags items are missing. Use Page.revisions() instead.'), ('.contributions(', 'User.contributions() returns a pywikibot.Timestamp object instead of a\n' 'MediaWiki one'),