jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/508094 ) Change subject: [TEST] fix test_login_logout ...................................................................... [TEST] fix test_login_logout - The tests worked locally, on the WM CI but not on Travis. It seems that the login is in progress while expected as completed. Added this case. Bug: T222508 Change-Id: I1dd500880ce6f2f995953c815fb24f0989e30b11 --- M tests/site_tests.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_tests.py b/tests/site_tests.py index d157f48..8d3f40e 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -3713,10 +3713,12 @@ loginstatus = pywikibot.site.LoginStatus self.assertFalse(site.logged_in()) + self.assertEqual(site._loginstatus, loginstatus.NOT_ATTEMPTED) site.login() self.assertTrue(site.logged_in()) - self.assertGreaterEqual(site._loginstatus, loginstatus.AS_USER) + self.assertIn(site._loginstatus, (loginstatus.IN_PROGRESS, + loginstatus.AS_USER)) self.assertIn('_userinfo', site.__dict__.keys()) self.assertIsNone(site.login()) -- To view, visit https://gerrit.wikimedia.org/r/508094 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1dd500880ce6f2f995953c815fb24f0989e30b11 Gerrit-Change-Number: 508094 Gerrit-PatchSet: 2 Gerrit-Owner: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)