jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/501892 )
Change subject: [bugfix] Terminate script if mandatory options aren't given
......................................................................
[bugfix] Terminate script if mandatory options aren't given
Bug: T220261
Change-Id: I84c5c0966177a7430359b102cdb333a865bbb6f7
---
M scripts/create_categories.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
D3r1ck01: Looks good to me, but someone else must approve
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/create_categories.py b/scripts/create_categories.py
index 3111b86..af13e2b 100755
--- a/scripts/create_categories.py
+++ b/scripts/create_categories.py
@@ -32,8 +32,8 @@
"""
#
# (C) Multichill, 2011
-# (C) xqt, 2011-2018
-# (c) Pywikibot team, 2013-2018
+# (C) xqt, 2011-2019
+# (c) Pywikibot team, 2013-2019
#
# Distributed under the terms of the MIT license.
#
@@ -110,7 +110,7 @@
missing.add('-basename')
generator = gen_factory.getCombinedGenerator()
- if generator and missing:
+ if generator and not missing:
bot = CreateCategoriesBot(generator, parent, basename, **options)
bot.run()
pywikibot.output('All done')
--
To view, visit
https://gerrit.wikimedia.org/r/501892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I84c5c0966177a7430359b102cdb333a865bbb6f7
Gerrit-Change-Number: 501892
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Multichill <maarten(a)mdammers.nl>
Gerrit-Reviewer: jenkins-bot (75)