jenkins-bot has submitted this change and it was merged.
Change subject: Introduce config.weblink_dead_days instead of day
......................................................................
Introduce config.weblink_dead_days instead of day
Renamed the variable day and add it to 'config2.py'
Port of pywikibot-compat 6bf00712
Bug: T76294
Change-Id: Ic95c31ecc7dbb557db8319b5857a4e94e4347db6
---
M pywikibot/config2.py
M scripts/weblinkchecker.py
2 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/config2.py b/pywikibot/config2.py
index 5f82eaa..5547271 100644
--- a/pywikibot/config2.py
+++ b/pywikibot/config2.py
@@ -622,6 +622,9 @@
report_dead_links_on_talk = False
+# Don't alert on links days_dead old or younger
+weblink_dead_days = 7
+
# ############# DATABASE SETTINGS ##############
# Setting to connect the database or replica of the database of the wiki.
# db_name_format can be used to manipulate the dbName of site.
diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index 86c0da7..5bd54da 100755
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -53,8 +53,9 @@
-notalk Overrides the report_dead_links_on_talk config variable, disabling
the feature.
--day the first time found dead link longer than x day ago, it should
- probably be fixed or removed. if no set, default is 7 day.
+
+-day Do not report broken link if the link is there only since
+ x days or less. If not set, the default is 7 days.
The following config variables are supported:
@@ -70,6 +71,9 @@
links on the article's talk page if (and ONLY if)
the linked page has been unavailable at least two
times during a timespan of at least one week.
+
+weblink_dead_days - sets the timespan (default: one week) after which
+ a dead link will be reported
Syntax examples:
python pwb.py weblinkchecker -start:!
@@ -563,7 +567,8 @@
else:
pywikibot.output('*[[%s]] links to %s - %s.'
% (self.page.title(), self.url, message))
- self.history.setLinkDead(self.url, message, self.page, self.day)
+ self.history.setLinkDead(self.url, message, self.page,
+ config.weblink_dead_days)
class History(object):
@@ -637,7 +642,7 @@
self.reportThread.report(url, errorReport, containingPage,
archiveURL)
- def setLinkDead(self, url, error, page, day):
+ def setLinkDead(self, url, error, page, weblink_dead_days):
"""Add the fact that the link was found dead to the .dat
file."""
self.semaphore.acquire()
now = time.time()
@@ -651,7 +656,7 @@
# if the first time we found this link longer than x day ago
# (default is a week), it should probably be fixed or removed.
# We'll list it in a file so that it can be removed manually.
- if timeSinceFirstFound > 60 * 60 * 24 * day:
+ if timeSinceFirstFound > 60 * 60 * 24 * weblink_dead_days:
# search for archived page
try:
archiveURL = get_archive_url(url)
@@ -886,7 +891,6 @@
gen = None
xmlFilename = None
HTTPignore = []
- day = 7
if isinstance(memento_client, ImportError):
warn('memento_client not imported: %s' % memento_client, ImportWarning)
@@ -905,7 +909,7 @@
elif arg.startswith('-ignore:'):
HTTPignore.append(int(arg[8:]))
elif arg.startswith('-day:'):
- day = int(arg[5:])
+ config.weblink_dead_days = int(arg[5:])
elif arg.startswith('-xmlstart'):
if len(arg) == 9:
xmlStart = pywikibot.input(
@@ -935,7 +939,7 @@
pageNumber = max(240, config.max_external_links * 2)
gen = pagegenerators.PreloadingGenerator(gen, step=pageNumber)
gen = pagegenerators.RedirectFilterPageGenerator(gen)
- bot = WeblinkCheckerRobot(gen, HTTPignore, day)
+ bot = WeblinkCheckerRobot(gen, HTTPignore, config.weblink_dead_days)
try:
bot.run()
finally:
--
To view, visit
https://gerrit.wikimedia.org/r/259179
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic95c31ecc7dbb557db8319b5857a4e94e4347db6
Gerrit-PatchSet: 6
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mhutti1 <mhutti1(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>