jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/314857 )
Change subject: [IMPR] Provide generator settings inside (user-)fixes.py
......................................................................
[IMPR] Provide generator settings inside (user-)fixes.py
- Generator has the keyword 'generator' and may be a str
or a iterable of str which enables multiple pagegenerators arguments
- The fixes generator is invoked only if no generator is given by command
line. This enables to override the default generator given by the fixes set.
Bug: T147418
Change-Id: Id099b50b766fb87678807a2a209c5bd2dd824245
---
M scripts/replace.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Huji: Looks good to me, approved
jenkins-bot: Verified
Zoranzoki21: Looks good to me, but someone else must approve
diff --git a/scripts/replace.py b/scripts/replace.py
index 1abd206..cd39f4c 100755
--- a/scripts/replace.py
+++ b/scripts/replace.py
@@ -128,7 +128,7 @@
"""
#
# (C) Daniel Herding, 2004-2012
-# (C) Pywikibot team, 2004-2016
+# (C) Pywikibot team, 2004-2017
#
# Distributed under the terms of the MIT license.
#
@@ -1023,6 +1023,7 @@
# Perform one of the predefined actions.
missing_fixes_summaries = [] # which a fixes/replacements miss a summary
+ generators_given = bool(genFactory.gens)
for fix_name in fixes_set:
try:
fix = fixes.fixes[fix_name]
@@ -1044,6 +1045,12 @@
set_summary = i18n.translate(site, fix['msg'], fallback=True)
else:
set_summary = None
+ if not generators_given and 'generator' in fix:
+ gen_args = fix['generator']
+ if isinstance(gen_args, basestring):
+ gen_args = [gen_args]
+ for gen_arg in gen_args:
+ genFactory.handleArg(gen_arg)
replacement_set = ReplacementList(fix.get('regex'),
fix.get('exceptions'),
fix.get('nocase'),
--
To view, visit
https://gerrit.wikimedia.org/r/314857
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id099b50b766fb87678807a2a209c5bd2dd824245
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Huji <huji.huji(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <dori.gord(a)orion.rs>
Gerrit-Reviewer: jenkins-bot <>