jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/475342 )
Change subject: [cleanup] Remove unused code in 1 script
......................................................................
[cleanup] Remove unused code in 1 script
Removed an unused function parameter in imagecopy.py
and added remove_last_args decorator to safely
deprecate
Bug: T203395
Change-Id: Ia7200f5f6c6ff184ca1445ec66058dfbfc0f907a
---
M scripts/imagecopy.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/imagecopy.py b/scripts/imagecopy.py
index 96d922b..6fffa02 100644
--- a/scripts/imagecopy.py
+++ b/scripts/imagecopy.py
@@ -84,6 +84,7 @@
from pywikibot import config, i18n, pagegenerators
from pywikibot.comms.http import fetch
from pywikibot.specialbots import UploadRobot
+from pywikibot.tools import remove_last_args
from scripts.image import ImageRobot
@@ -392,8 +393,8 @@
"""The dialog window for image info."""
- def __init__(self, image_title, content, uploader, url, templates,
- commonsconflict=0):
+ @remove_last_args(('commonsconflict',))
+ def __init__(self, image_title, content, uploader, url, templates):
"""Initializer."""
# Check if `Tkinter` wasn't imported
if isinstance(Tkinter, ImportError):
--
To view, visit
https://gerrit.wikimedia.org/r/475342
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7200f5f6c6ff184ca1445ec66058dfbfc0f907a
Gerrit-Change-Number: 475342
Gerrit-PatchSet: 3
Gerrit-Owner: Arcayn <arcaynnnnnn(a)gmail.com>
Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)