jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1295701?usp=email )
Change subject: [bugfix] Prevent ignored generator option from leaking into kwargs ......................................................................
[bugfix] Prevent ignored generator option from leaking into kwargs
Bug: T427740 Change-Id: Ie19682bc6f60ec262ec2ca1e577a4700fc0ed179 --- M pywikibot/bot.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/bot.py b/pywikibot/bot.py index f873950..3fa100e 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -1171,11 +1171,12 @@ method """ if 'generator' in kwargs: + gen = kwargs.pop('generator') if hasattr(self, 'generator'): warnings.warn(f'{type(self).__name__} has a generator' ' already. Ignoring argument.', stacklevel=2) else: - self.generator: Iterable = kwargs.pop('generator') + self.generator: Iterable = gen
self.available_options.update(self.update_options) super().__init__(**kwargs)