jenkins-bot submitted this change.

View Change

[bugfix] remove question mark character from forbidden file name characters

The forbidden chars were introduced sometime before 2006 when some code
parts was moved from interwiki.py script to interwiki_graph module. The
original variant of compat's upload module only had '\\' as forbidden
char and other checks are also made within page module especially inside
Link initializer. Therefore I think the question mark kan safely be
removed here.

Bug: T93482
Change-Id: Iabbe639dce2bf42a422f59f7335df978473a3984
---
M pywikibot/specialbots/_upload.py
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pywikibot/specialbots/_upload.py b/pywikibot/specialbots/_upload.py
index 20d9bb0..fe93944 100644
--- a/pywikibot/specialbots/_upload.py
+++ b/pywikibot/specialbots/_upload.py
@@ -243,7 +243,7 @@
                 filename = newfn
         # FIXME: these 2 belong somewhere else, presumably in family
         # forbidden characters are handled by pywikibot/page.py
-        forbidden = ':*?/\\'  # to be extended
+        forbidden = ':*/\\'  # to be extended
         try:
             allowed_formats = self.target_site.siteinfo.get(
                 'fileextensions', get_default=False)

To view, visit change 753092. To unsubscribe, or for help writing mail filters, visit settings.