jenkins-bot merged this change.

View Change

[bugfix] Set optional parameter namespace to None in site.logpages

- Deprecated site method logpages calls logevents.
  The namespace parameter is suppressed when it is None and not submitted
  to the api. An empty list is not None therefore the parameter is passed
  to the API and this will cause a warning thrown be api,set_namespace for
  older mediawiki version which doesnot support this parameter with
  logevents.
- Wikia has mw 1.19.24 currently and has no namespace support for logevents
  but it is not clear when this was introduced.
- Skip site_tests.TestLogPages.test_list_namespace for mw <= 1.19.24
- The other failing methods of T217664 are solved with the new default
  value of the optional parameter above.

Bug: T217664
Change-Id: I11f4746461dce3ca1810b036ec74104809d52f10
---
M pywikibot/site.py
M tests/site_tests.py
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/pywikibot/site.py b/pywikibot/site.py
index 26c11c4..99af4e7 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -4678,7 +4678,7 @@
     @deprecated('APISite.logevents()', since='20141225')
     @deprecated_args(repeat=None)
     def logpages(self, number=50, mode=None, title=None, user=None,
-                 namespace=[], start=None, end=None, tag=None, newer=False,
+                 namespace=None, start=None, end=None, tag=None, newer=False,
                  dump=False, offset=None):
         """
         Iterate log pages. DEPRECATED.
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 5c9069c..c007217 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1358,6 +1358,10 @@
 
     def test_list_namespace(self):
         """Test the deprecated site.logpages() when namespace is a list."""
+        if self.site.mw_version <= '1.19.24':  # T217664
+            self.skipTest(
+                'logevents does not support namespace parameter with MediaWiki'
+                ' {}.'.format(self.site.mw_version))
         le = list(self.site.logpages(namespace=[2, 3], number=10))
         for entry in le:
             if isinstance(entry[0], int):  # autoblock removal entry

To view, visit change 497519. To unsubscribe, or for help writing mail filters, visit settings.