DrTrigon has posted comments on this change.
Change subject: bug fix; follow-up to change-set 76450, a $Id$ was removed accidentially bug fix; regex adopted to new $Id$ format
......................................................................
Patch Set 2:
1 - '(.*)' CAN be improved to '(\w+)'
2 - '%(S)s' CANNOT be simplified to '$' because then git will replace it with the actual value (see [1] this is the main reason for this patch)
[1] https://gerrit.wikimedia.org/r/#/c/76450/2/pywikibot/bot.py
--
To view, visit
https://gerrit.wikimedia.org/r/76453
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie468cdcbcd0bed470a158fa4f5edb879d25a889c
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: DrTrigon
dr.trigon@surfeu.ch
Gerrit-Reviewer: DrTrigon
dr.trigon@surfeu.ch
Gerrit-Reviewer: Ladsgroup
ladsgroup@gmail.com
Gerrit-Reviewer: Legoktm
legoktm.wikipedia@gmail.com
Gerrit-Reviewer: Merlijn van Deen
valhallasw@arctus.nl
Gerrit-Reviewer: PywikibotCommitWatcher
pywikibot-commits@lists.wikimedia.org
Gerrit-Reviewer: Xqt
info@gno.de
Gerrit-Reviewer: jenkins-bot
Gerrit-HasComments: No