jenkins-bot submitted this change.

View Change


Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[tests] Fix obsolete type in TestGenerateFamilyFile

interwiki_removals is either a frozen_set or a list

Bug: T334714
Change-Id: I573954fd3a92d22269708b6f58cee1bd58616d66
---
M tests/generate_family_file_tests.py
1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/tests/generate_family_file_tests.py b/tests/generate_family_file_tests.py
index f219ac6..ea9e0b8 100755
--- a/tests/generate_family_file_tests.py
+++ b/tests/generate_family_file_tests.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
"""Test generate_family_file script."""
#
-# (C) Pywikibot team, 2018-2022
+# (C) Pywikibot team, 2018-2023
#
# Distributed under the terms of the MIT license.
#
@@ -37,7 +37,7 @@
"""Pass writing."""


-class TestGenerateFamilyFiles(DefaultSiteTestCase):
+class TestGenerateFamilyFile(DefaultSiteTestCase):

"""Test generate_family_file functionality."""

@@ -80,7 +80,9 @@
with self.subTest(test='Test element counts'):
if self.site.lang not in gen.prefixes:
gen.prefixes.append(self.site.lang)
- obsolete = self.site.family.interwiki_removals
+
+ # interwiki_removals is either a frozen_set or a list
+ obsolete = set(self.site.family.interwiki_removals)
self.assertCountEqual(set(gen.prefixes) - obsolete,
set(gen.wikis) - obsolete)


To view, visit change 908886. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I573954fd3a92d22269708b6f58cee1bd58616d66
Gerrit-Change-Number: 908886
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged