jenkins-bot merged this change.

View Change

Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified
[test] Test EventStreams repr method

Change-Id: I14192f70125cb72a30ab52ecb8eff99578cc014c
---
M tests/eventstreams_tests.py
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/eventstreams_tests.py b/tests/eventstreams_tests.py
index a033dc0..dd3ecfd 100644
--- a/tests/eventstreams_tests.py
+++ b/tests/eventstreams_tests.py
@@ -10,7 +10,7 @@
from tests import mock

from pywikibot.comms.eventstreams import EventStreams
-from pywikibot import config
+from pywikibot import config, Site
from pywikibot.family import WikimediaFamily

from tests.aspects import unittest, TestCase, DefaultSiteTestCase
@@ -42,6 +42,9 @@
self.assertEqual(e._url, e.sse_kwargs.get('url'))
self.assertIsNone(e._total)
self.assertIsNone(e._stream)
+ self.assertEqual(repr(e),
+ "EventStreams(url='{}')"
+ .format(self.sites[key]['hostname']))

def test_url_from_site(self, key):
"""Test EventStreams with url from site."""
@@ -54,6 +57,10 @@
self.assertEqual(e._url, e.sse_kwargs.get('url'))
self.assertIsNone(e._total)
self.assertEqual(e._stream, stream)
+ site_repr = 'site={}, '.format(repr(site)) if site != Site() else ''
+ self.assertEqual(repr(e),
+ "EventStreams({}stream='{}')"
+ .format(site_repr, stream))


@mock.patch('pywikibot.comms.eventstreams.EventSource', new=mock.MagicMock())

To view, visit change 437063. To unsubscribe, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I14192f70125cb72a30ab52ecb8eff99578cc014c
Gerrit-Change-Number: 437063
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot <>