jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
refactor(config2): remove the unimplemented proxy variable

Users can use environment variables to setup a proxy as mentioned in [1].
Users who already have this unused variable in their user-config.py file
will now recieve the following warning:

"""
UserWarning: Configuration variable "proxy" is defined in your \
user-config.py but unknown. It can be a misspelled one or a variable
that is no longer supported.
"""

[1]:
https://www.mediawiki.org/w/index.php?title=Manual:Pywikibot/Installation&diff=3318238&oldid=3315748

Bug: T111752
Change-Id: Ife62e94d13fc6c33e8a19a49bf855f26cbb49a65
---
M pywikibot/config2.py
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/pywikibot/config2.py b/pywikibot/config2.py
index e8316a2..b405b79 100644
--- a/pywikibot/config2.py
+++ b/pywikibot/config2.py
@@ -108,7 +108,7 @@
# variables that are intended only for internal use and not to be exported
# to other modules.

-_private_values = {'authenticate', 'proxy', 'db_password'}
+_private_values = {'authenticate', 'db_password'}
_deprecated_variables = {'use_SSL_onlogin', 'use_SSL_always',
'available_ssl_project', 'fake_user_agent',
'special_page_limit'}
@@ -874,11 +874,6 @@

# ############# FURTHER SETTINGS ##############

-# Proxy configuration
-
-# TODO: proxy support
-proxy = None
-
# Simulate settings

# Defines what additional actions the bots are NOT allowed to do (e.g. 'edit')

To view, visit change 523529. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife62e94d13fc6c33e8a19a49bf855f26cbb49a65
Gerrit-Change-Number: 523529
Gerrit-PatchSet: 1
Gerrit-Owner: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)