jenkins-bot merged this change.

View Change

Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
[bugfix] fix script_deps in script_tests.py

script_tests.check_script_deps checks for installed modules
but not for version dependecies. Therefore remove version
dependencies and enable related tests

Bug: T243169
Change-Id: I35afb4fcecba5b237614d7f4b42112bb8a2aac5f
---
M tests/script_tests.py
1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/tests/script_tests.py b/tests/script_tests.py
index 5a86380..8f5db09 100644
--- a/tests/script_tests.py
+++ b/tests/script_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Test that each script can be compiled and executed."""
#
-# (C) Pywikibot team, 2014-2019
+# (C) Pywikibot team, 2014-2020
#
# Distributed under the terms of the MIT license.
#
@@ -20,18 +20,15 @@
scripts_path = join_root_path('scripts')

# These dependencies are not always the package name which is in setup.py.
-# e.g. 'PIL.ImageTk' is a object provided by several different pypi packages,
-# and setup.py requests that 'Pillow' is installed to provide 'PIL.ImageTk'.
-# Here, it doesn't matter which pypi package was requested and installed.
# Here, the name given to the module which will be imported is required.
script_deps = {
- 'flickrripper': ['flickrapi', 'Pillow'],
+ 'flickrripper': ['flickrapi', 'PIL'],
'imageharvest': ['bs4'],
'isbn': ['python-stdnum'],
- 'match_images': ['PIL.ImageTk'],
+ 'match_images': ['PIL.Image'],
'states_redirect': ['pycountry'],
- 'patrol': ['mwparserfromhell>=0.3.3'],
- 'weblinkchecker': ['memento_client>=0.5.1,!=0.6.0'],
+ 'patrol': ['mwparserfromhell'],
+ 'weblinkchecker': ['memento_client'],
}

if PY2:

To view, visit change 563711. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I35afb4fcecba5b237614d7f4b42112bb8a2aac5f
Gerrit-Change-Number: 563711
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)