jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[Cleanup] Remove unused variables and unreachanble code

Fixed the following instances:
scripts\script_wui.py:310: unsatisfiable 'if' condition

Bug: T203395
Change-Id: Iffb96aef4398ab2f9842de9ad18548fe83344442
---
M scripts/script_wui.py
1 file changed, 0 insertions(+), 5 deletions(-)

diff --git a/scripts/script_wui.py b/scripts/script_wui.py
index a1bfbb6..d405e85 100755
--- a/scripts/script_wui.py
+++ b/scripts/script_wui.py
@@ -304,11 +304,6 @@

def wiki_logger(buffer, page, rev=None):
"""Log to wiki."""
- # FIXME: what is this??
- # (might be a problem here for TS and SGE, output string has another
- # encoding)
- if False:
- buffer = buffer.decode(pywikibot.config.console_encoding)
buffer = re.sub(r'\03\{(.*?)\}(.*?)\03\{default\}', r'\g<2>', buffer)
if rev is None:
rev = page.latestRevision()

To view, visit change 477947. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffb96aef4398ab2f9842de9ad18548fe83344442
Gerrit-Change-Number: 477947
Gerrit-PatchSet: 11
Gerrit-Owner: YVB <yajnvb@gmail.com>
Gerrit-Reviewer: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)