jenkins-bot submitted this change.

View Change


Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[doc] Update ROADMAP.rst and CHANGELOG.rst

- add version hints
- PagePilePageGenerator is derived from collections.abc.Generator
and can be used directly

Change-Id: I215109a473dc2e9c1671d9feb6cc3c734500cbb7
---
M ROADMAP.rst
M pywikibot/pagegenerators/_generators.py
M scripts/CHANGELOG.rst
M pywikibot/site/_namespace.py
M pywikibot/pagegenerators/_factory.py
M tests/pagegenerators_tests.py
6 files changed, 41 insertions(+), 11 deletions(-)

diff --git a/ROADMAP.rst b/ROADMAP.rst
index 8718fb4..b276f64 100644
--- a/ROADMAP.rst
+++ b/ROADMAP.rst
@@ -4,12 +4,14 @@
Improvements
^^^^^^^^^^^^

-* (no changes yet)
+* L10N Updates
+* Add :class:`pagegenerators.PagePilePageGenerator` (:phab:`T353086`)

Bugfixes
^^^^^^^^

-* (no changes yet)
+* :func:`pywikibot.input_choice` validates *default* parameter (:phab:`T353097`)
+* Remove typing imports from user-config.py file (:phab:`T352965`)

Breaking changes and code cleanups
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/pywikibot/pagegenerators/_factory.py b/pywikibot/pagegenerators/_factory.py
index 47cb2ec..79fec88 100644
--- a/pywikibot/pagegenerators/_factory.py
+++ b/pywikibot/pagegenerators/_factory.py
@@ -927,12 +927,14 @@
return True

def _handle_pagepile(self, value: str) -> HANDLER_RETURN_TYPE:
- """Handle `-pagepile` argument."""
+ """Handle `-pagepile` argument.
+
+ .. versionadded:: 9.0
+ """
if not value.isnumeric():
raise ValueError(
- f'PagePile id must be an int. I was given "{value}"')
- pile = PagePilePageGenerator(int(value))
- return pile.generator
+ f'PagePile id must be an int. It was given "{value}"')
+ return PagePilePageGenerator(int(value))

def handle_args(self, args: Iterable[str]) -> list[str]:
"""Handle command line arguments and return the rest as a list.
diff --git a/pywikibot/pagegenerators/_generators.py b/pywikibot/pagegenerators/_generators.py
index 8129c20..296640b 100644
--- a/pywikibot/pagegenerators/_generators.py
+++ b/pywikibot/pagegenerators/_generators.py
@@ -1238,7 +1238,6 @@

.. seealso:: https://pagepile.toolforge.org/
.. versionadded:: 9.0
- subclassed from :class:`tools.collections.GeneratorWrapper`
"""

def __init__(self, id: int):
diff --git a/pywikibot/site/_namespace.py b/pywikibot/site/_namespace.py
index b7ff4b7..11b1e54 100644
--- a/pywikibot/site/_namespace.py
+++ b/pywikibot/site/_namespace.py
@@ -1,6 +1,6 @@
"""Objects representing Namespaces of MediaWiki site."""
#
-# (C) Pywikibot team, 2008-2022
+# (C) Pywikibot team, 2008-2023
#
# Distributed under the terms of the MIT license.
#
@@ -53,7 +53,11 @@


class MetaNamespace(ABCMeta):
- """Metaclass for Namespace attribute settings."""
+
+ """Metaclass for Namespace attribute settings.
+
+ .. versionadded:: 9.0
+ """

def __new__(cls, name, bases, dic):
"""Set Namespace.FOO to BuiltinNamespace.FOO for each builtin ns."""
@@ -79,6 +83,9 @@

If only one of canonical_name and custom_name are available, both
properties will have the same value.
+
+ .. versionchanged:: 9.0
+ metaclass from :class:`MetaNamespace`
"""

def __init__(self, id,
diff --git a/scripts/CHANGELOG.rst b/scripts/CHANGELOG.rst
index bdc4501..23f8739 100644
--- a/scripts/CHANGELOG.rst
+++ b/scripts/CHANGELOG.rst
@@ -1,6 +1,14 @@
Scripts Changelog
=================

+9.0.0
+-----
+
+category_redirect
+~~~~~~~~~~~~~~~~~
+
+* provide category_redirect categories for all WM sites (:phab:`T348914`)
+
8.5.0
-----

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 811605f..0b16821 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -408,8 +408,7 @@
def test_PagePilePageGenerator(self):
"""Test PagePilePageGenerator."""
gen = pagegenerators.PagePilePageGenerator(id=53158)
- pages = list(gen.generator)
- self.assertLength(pages, 215)
+ self.assertLength(list(gen), 215)
self.assertEqual(gen.site, pywikibot.Site('wikipedia:ro'))



To view, visit change 981663. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I215109a473dc2e9c1671d9feb6cc3c734500cbb7
Gerrit-Change-Number: 981663
Gerrit-PatchSet: 5
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <dalangi-ctr@wikimedia.org>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged