jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[fix] Don't test Python's behaviour

It is impossible to test that islice_with_ellipsis accepts 'marker'
as keyword if the function was modified. The test only tests for 't'
and the test can pass for other parameters if implemented. This test
is mainly useless.

Change-Id: I5259fafd0662e4ef3f392811c75b349623260e71
---
M tests/tools_tests.py
1 file changed, 0 insertions(+), 7 deletions(-)

diff --git a/tests/tools_tests.py b/tests/tools_tests.py
index d6a6f6e..77e57e4 100644
--- a/tests/tools_tests.py
+++ b/tests/tools_tests.py
@@ -342,13 +342,6 @@
self.assertEqual(it, self.it)
self.assertNotEqual(it[-1], '…')

- def test_accept_only_keyword_marker(self):
- """Test that the only kwargs accepted is 'marker'."""
- with self.assertRaisesRegex(TypeError,
- r'islice_with_ellipsis\(\) got an '
- "unexpected keyword argument 't'"):
- tools.islice_with_ellipsis(self.it, 1, t='')
-

def passthrough(x):
"""Return x."""

To view, visit change 673474. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I5259fafd0662e4ef3f392811c75b349623260e71
Gerrit-Change-Number: 673474
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged