jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/673474 )
Change subject: [fix] Don't test Python's behaviour ......................................................................
[fix] Don't test Python's behaviour
It is impossible to test that islice_with_ellipsis accepts 'marker' as keyword if the function was modified. The test only tests for 't' and the test can pass for other parameters if implemented. This test is mainly useless.
Change-Id: I5259fafd0662e4ef3f392811c75b349623260e71 --- M tests/tools_tests.py 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/tools_tests.py b/tests/tools_tests.py index d6a6f6e..77e57e4 100644 --- a/tests/tools_tests.py +++ b/tests/tools_tests.py @@ -342,13 +342,6 @@ self.assertEqual(it, self.it) self.assertNotEqual(it[-1], '…')
- def test_accept_only_keyword_marker(self): - """Test that the only kwargs accepted is 'marker'.""" - with self.assertRaisesRegex(TypeError, - r'islice_with_ellipsis() got an ' - "unexpected keyword argument 't'"): - tools.islice_with_ellipsis(self.it, 1, t='') -
def passthrough(x): """Return x."""