jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[bugfix] Fix and clean up DataSite.get_property_by_name

The result should be upper cased, not the message.

Change-Id: Idb616f77952c38bb70ea842316c889f2b73d24d3
---
M pywikibot/bot.py
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index afac80c..06b2574 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -1991,16 +1991,15 @@
:param property_name: property to find
:type property_name: str
"""
- ns = self.site.data_repository().property_namespace
- for page in self.site.search(property_name, total=1, namespaces=ns):
- page = pywikibot.PropertyPage(self.site.data_repository(),
- page.title())
+ ns = self.repo.property_namespace
+ for page in self.repo.search(property_name, total=1, namespaces=ns):
+ page = pywikibot.PropertyPage(self.repo, page.title())
pywikibot.output('Assuming that {} property is {}.'
.format(property_name, page.id))
return page.id
return pywikibot.input('Property {} was not found. Please enter the '
'property ID (e.g. P123) of it:'
- .format(property_name).upper())
+ .format(property_name)).upper()

def user_edit_entity(self, entity, data=None,
ignore_save_related_errors=None,

To view, visit change 702337. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Idb616f77952c38bb70ea842316c889f2b73d24d3
Gerrit-Change-Number: 702337
Gerrit-PatchSet: 1
Gerrit-Owner: Matěj Suchánek <matejsuchanek97@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged