jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
pagegenerators._handle_recentchanges: Do not request for reversed results

Bug: T199199
Change-Id: I0e81cb6b8f70a09ea6f1c9c9c6f470a66dd466e7
---
M pywikibot/pagegenerators.py
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 29e058a..ec5a83b 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -811,14 +811,13 @@
if offset < 0 or duration < 0:
raise ValueError('Negative valued parameters passed.')
ts_time = self.site.server_time()
- rcstart = ts_time + timedelta(minutes=-(offset + duration))
- rcend = ts_time + timedelta(minutes=-offset)
+ rcstart = ts_time - timedelta(minutes=offset)
+ rcend = rcstart - timedelta(minutes=duration)
elif len(params) == 1:
total = int(params[0])
return RecentChangesPageGenerator(
namespaces=self.namespaces, total=total, start=rcstart, end=rcend,
- site=self.site, reverse=True, tag=rctag,
- _filter_unique=self._filter_unique)
+ site=self.site, tag=rctag, _filter_unique=self._filter_unique)

def _handle_liverecentchanges(self, value):
"""Handle `-liverecentchanges` argument."""

To view, visit change 445392. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e81cb6b8f70a09ea6f1c9c9c6f470a66dd466e7
Gerrit-Change-Number: 445392
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuyifei1999 <zhuyifei1999@gmail.com>
Gerrit-Reviewer: AdityaJ <adi2007jain@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot (75)
Gerrit-CC: Dalba <dalba.wiki@gmail.com>