jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
Removing @TODOs

@TODOs were not meant to have been merged with the patchset. They
have been replaced with the following tasks.

Bug: T223889
Bug: T223890
Bug: T223891
Bug: T223897
Change-Id: I6f79c1ea55b0f1de0a8f33fb8ad78659c6c8c633
---
M pywikibot/page.py
1 file changed, 0 insertions(+), 7 deletions(-)

diff --git a/pywikibot/page.py b/pywikibot/page.py
index 7013850..062ec9d 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -5609,9 +5609,6 @@
"""
Look up the namespace given the provided namespace id or name.

- @TODO Invalid namespaces are ignored as per Link.__init__,
- ideally both should raise some type of exception.
-
@rtype: pywikibot.Namespace
"""
default_nskey = Namespace.MAIN
@@ -5783,8 +5780,6 @@
following a '|' character inside the link
"""

- # @TODO Kept as is to not change repr() but is it suitable when missing
- # 3 of 5 attributes?
# Components used for __repr__
_items = ('title', 'site')

@@ -6090,7 +6085,6 @@
self.parse()
return self._anchor

- # @TODO: shouldn't anchor also be added?
def astext(self, onsite=None):
"""
Return a text representation of the link.
@@ -6107,7 +6101,6 @@

return text

- # @TODO: Left as is but shouldn't section be included per description?
def _cmpkey(self):
"""
Key for comparison of Link objects.

To view, visit change 511399. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f79c1ea55b0f1de0a8f33fb8ad78659c6c8c633
Gerrit-Change-Number: 511399
Gerrit-PatchSet: 2
Gerrit-Owner: Lokal Profil <andre.costa@wikimedia.se>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)