[Pywikibot-commits] [Gerrit] Introduce set_redirect_target method in Page class - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Introduce set_redirect_target method in Page class ...................................................................... Introduce set_redirect_target method in Page class It set target of redirect page any given page or page and section. It also can create the redirect or change an ordinary page to a redirect. The main reason to do this is that It can be altered to support set redirect in subclasses like ItemPage or CategoryPage and be used generally. Added one example in the capitalize_redirects script. Change-Id: Idbe5a1c3e6bb43afe019823fd5eb120c00d9dbec --- M pywikibot/page.py M scripts/capitalize_redirects.py 2 files changed, 59 insertions(+), 7 deletions(-) Approvals: XZise: Looks good to me, but someone else must approve Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index ad0a643..abfda80 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -1911,6 +1911,63 @@ result.append((pywikibot.Page(link, self.site), positional)) return result + def set_redirect_target(self, target_page, create=False, force=False, + keep_section=False, **kwargs): + """ + Change the page's text to point to the redirect page. + + @param target_page: target of the redirect, this argument is required. + @type target_page: pywikibot.Page or string + @param summary: The edit summary which must be set if the page should + be saved too. If omitted the page won't be saved. + @type summary: string + @param create: if true, it creates the redirect even if the page + doesn't exist. + @type create: bool + @param force: if true, it set the redirect target even the page + doesn't exist or it's not redirect. + @type force: bool + @param keep_section: if the old redirect links to a section + and the new one doesn't it uses the old redirect's section. + @type keep_section: bool + @param kwargs: Arguments which are used for saving the page directly + afterwards. If none are provided the page isn't saved. + """ + if isinstance(target_page, basestring): + target_page = pywikibot.Page(self.site, target_page) + elif self.site != target_page.site: + raise pywikibot.InterwikiRedirectPage(self, target_page) + if not self.exists() and not (create or force): + raise pywikibot.NoPage(self) + if self.exists() and not self.isRedirectPage() and not force: + raise pywikibot.IsNotRedirectPage(self) + redirect_regex = self.site.redirectRegex() + if self.exists(): + old_text = self.get(get_redirect=True) + else: + old_text = u'' + result = redirect_regex.search(old_text) + if result: + oldlink = result.group(1) + if keep_section and '#' in oldlink and target_page.section() is None: + sectionlink = oldlink[oldlink.index('#'):] + target_page = pywikibot.Page( + self.site, + target_page.title() + sectionlink + ) + prefix = self.text[:result.start()] + suffix = self.text[result.end():] + else: + prefix = '' + suffix = '' + + target_link = target_page.title(asLink=True, textlink=True, + allowInterwiki=False) + target_link = '#{0} {1}'.format(self.site.redirect(), target_link) + self.text = prefix + target_link + suffix + if kwargs: + self.save(**kwargs) + class FilePage(Page): diff --git a/scripts/capitalize_redirects.py b/scripts/capitalize_redirects.py index 05a388e..42fe6c1 100644 --- a/scripts/capitalize_redirects.py +++ b/scripts/capitalize_redirects.py @@ -85,13 +85,8 @@ site, 'capitalize_redirects-create-redirect', {'to': page_t}) - page_cap.text = u"#%s %s" % (site.redirect(), - self.current_page.title( - asLink=True, textlink=True)) - try: - page_cap.save(comment) - except: - pywikibot.output(u"An error occurred, skipping...") + page_cap.set_redirect_target(self.current_page, create=True, + summary=comment) def main(*args): -- To view, visit https://gerrit.wikimedia.org/r/185159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe5a1c3e6bb43afe019823fd5eb120c00d9dbec Gerrit-PatchSet: 12 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: Ricordisamoa &lt;ricordisamoa(a)openmailbox.org&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>