Legoktm has posted comments on this change.
Change subject: improvement; remove simplejson from git submodule and externals
management
......................................................................
Patch Set 2: Code-Review-1
You also need to remove all the instances where it is currently used (via a simple grep):
- generate_family_file.py: import simplejson as json # after 'wikipedia'
because of externals path
- panoramiopicker.py: import simplejson as json # after 'wikipedia' because
of externals path
- query.py: import simplejson as json # after 'wikipedia' because of
externals path
- wikipedia.py: import simplejson as json
--
To view, visit
https://gerrit.wikimedia.org/r/76350
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e2e9ca1c631088674fff7728e9a82df88bcf22
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-HasComments: No