jenkins-bot merged this change.

View Change

test(test_family_load_valid): do not care if languages_by_size is empty

I've created a few custom family files, e.g. for wpbeta, but they fail
this test because the autogenerated family files does not have a
languages_by_size attribute.

We have fixed and changed this part of test several times during these
years. I think it is not worth maintaning and is safe to remove.

Change-Id: Icffca034d26a82d9114da6c0668ac32bc07c060e
---
M tests/family_tests.py
1 file changed, 0 insertions(+), 4 deletions(-)

diff --git a/tests/family_tests.py b/tests/family_tests.py
index 8361090..6e24bee 100644
--- a/tests/family_tests.py
+++ b/tests/family_tests.py
@@ -52,10 +52,6 @@
             self.assertEqual(f.name, name)
             self.assertIsInstance(f.languages_by_size, list)
             self.assertGreaterEqual(set(f.langs), set(f.languages_by_size))
-            if len(f.langs) > 2 and f.name not in {
-                'wikimediachapter', 'vikidia', 'wikidata', 'wikimania'
-            }:
-                self.assertNotEqual(f.languages_by_size, [])
             if isinstance(f, SingleSiteFamily):
                 self.assertIsNotNone(f.code)
                 self.assertIsNotNone(f.domain)

To view, visit change 524209. To unsubscribe, or for help writing mail filters, visit settings.