jenkins-bot merged this change.

View Change

Approvals: JJMC89: Looks good to me, but someone else must approve Dalba: Looks good to me, approved jenkins-bot: Verified
[bugfix] Fix is_thankable expression

- self.isRegistered() implies not self.isAnonymous

Bug: T191146
Change-Id: I9867e19a1283c17fdb34cb0a90d7977c718bdf8a
---
M pywikibot/page.py
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pywikibot/page.py b/pywikibot/page.py
index 20b5491..ca95e0c 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3599,8 +3599,7 @@

@rtype: bool
"""
- return not (self.isAnonymous() or self.isRegistered()
- or 'bot' in self.groups())
+ return self.isRegistered() and 'bot' not in self.groups()


class WikibasePage(BasePage):

To view, visit change 423254. To unsubscribe, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9867e19a1283c17fdb34cb0a90d7977c718bdf8a
Gerrit-Change-Number: 423254
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot <>