 |
Build #4268 has errored. |
 |
 |
dalba | 5749b75 Changeset → |
| login.py: Unpack entry instead of overwriting itself - Open the password file in a with block to make sure it is always closed properly. - login_tests.py was mocking `codecs.open` and the returned object was not a context manager; therefore did not work with our new `with` statement. Use `io.StringIO` to make it work again. - Unpack `entry` into variables. This makes the code easier to follow and developers won't need to remember what each entry item means when examining the code. - Fix a minor bug in file line numbers. Line numbers start from 1, not 0. Reverse the order of reading lines, so that we can break the password search loop as soon as we find a matching password entry. This way the priority of password entries won't change. Change-Id: Ide50f0fd7d1baaa875907a17ed1e25801b6d472a |
||
 wikimedia / pywikibot-core (master) |
Want to know about upcoming build environment updates?
Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here.
|
Documentation about Travis CI Need help? Mail support! Choose who receives these build notification emails in your configuration file. |
Would you like to test your private code?
Travis CI for Private Projects could be your new best friend!