jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[bugfix]: Popen() does not expects int in args

Popen() accept as args:
- a str
- a seq of str, bytes or os.PathLike object, not int

Change-Id: I5a6067c9843bb58acf4a40ff925eb4a08c9a2826
---
M pywikibot/tools/djvu.py
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pywikibot/tools/djvu.py b/pywikibot/tools/djvu.py
index 3da4eda..02e7c4e 100644
--- a/pywikibot/tools/djvu.py
+++ b/pywikibot/tools/djvu.py
@@ -227,7 +227,7 @@
if not self.has_text(force=force):
raise ValueError('Djvu file {} has no text layer.'
.format(self.file))
- res, stdoutdata = _call_cmd(['djvutxt', f'--page={int(n)}',
+ res, stdoutdata = _call_cmd(['djvutxt', f'--page={n}',
self.file])
if not res:
return False
@@ -258,7 +258,7 @@
return False

# Convert white_page to djvu.
- res, data = _call_cmd(['c44', white_ppm, '-dpi', dpi])
+ res, data = _call_cmd(['c44', white_ppm, '-dpi', str(dpi)])
os.unlink(white_ppm) # rm white_page.ppm before returning.
if not res:
return False
@@ -266,12 +266,12 @@
# Delete page n.
# Get ref page info for later checks.
info_ref_page = self.page_info(ref_page)
- res, data = _call_cmd(['djvm', '-d', self.file, n])
+ res, data = _call_cmd(['djvm', '-d', self.file, str(n)])
if not res:
return False

# Insert new page
- res, data = _call_cmd(['djvm', '-i', self.file, white_djvu, n])
+ res, data = _call_cmd(['djvm', '-i', self.file, white_djvu, str(n)])
os.unlink(white_djvu) # rm white_page.djvu before returning.
if not res:
return False
@@ -300,7 +300,7 @@
# Delete page n.
# Get ref page info for later checks.
info_ref_page = self.page_info(ref_page)
- res, _ = _call_cmd(['djvm', '-d', self.file, n])
+ res, _ = _call_cmd(['djvm', '-d', self.file, str(n)])
if not res:
return False


To view, visit change 837210. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I5a6067c9843bb58acf4a40ff925eb4a08c9a2826
Gerrit-Change-Number: 837210
Gerrit-PatchSet: 2
Gerrit-Owner: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged