jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[cleanup] Show a FutureWarning for output stdout parameter

Bug: T85620
Change-Id: Ibf92ae07c0f2c06a4caeedd244053929b5008b09
---
M pywikibot/logging.py
M tests/ui_tests.py
2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/pywikibot/logging.py b/pywikibot/logging.py
index 0ac811e..0525cea 100644
--- a/pywikibot/logging.py
+++ b/pywikibot/logging.py
@@ -129,8 +129,9 @@
"""
if toStdout: # maintained for backwards-compatibity only
from pywikibot.tools import issue_deprecation_warning
- issue_deprecation_warning('"toStdout" parameter',
- 'pywikibot.stdout()', since='20160228')
+ issue_deprecation_warning('"toStdout" parameter', 'pywikibot.stdout()',
+ warning_class=FutureWarning,
+ since='20160228')
logoutput(text, decoder, newline, STDOUT, **kwargs)
else:
logoutput(text, decoder, newline, INFO, **kwargs)
diff --git a/tests/ui_tests.py b/tests/ui_tests.py
index 234c16a..6f1ad1f 100644
--- a/tests/ui_tests.py
+++ b/tests/ui_tests.py
@@ -264,7 +264,7 @@
pywikibot.output('output', toStdout=True)
self.assertEqual(newstdout.getvalue(), 'output\n')
self.assertLength(w, 1)
- self.assertEqual(w[0].category, DeprecationWarning)
+ self.assertEqual(w[0].category, FutureWarning)
message = str(w[0].message)
self.assertTrue(
message.startswith('"toStdout" parameter is deprecated'))

To view, visit change 649823. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ibf92ae07c0f2c06a4caeedd244053929b5008b09
Gerrit-Change-Number: 649823
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged