jenkins-bot submitted this change.

View Change

Approvals: Zoranzoki21: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified
[tests] Remove lyricwiki_family.py from framework

- lyrics.fandom.com was closed as announced and is no longer reachable.
Remove this family file from framework. lyrics.fandom.com/ru can still
be created via generate_family_file or AutoFamily.
- update docs/api_ref/pywikibot.families.rst
- update family_tests.py
- update logentries_tests.py

Bug: T245439
Change-Id: I809f5cf15938543e933d315407db11cf353ddcdf
---
M docs/api_ref/pywikibot.families.rst
D pywikibot/families/lyricwiki_family.py
M tests/family_tests.py
M tests/logentries_tests.py
4 files changed, 5 insertions(+), 31 deletions(-)

diff --git a/docs/api_ref/pywikibot.families.rst b/docs/api_ref/pywikibot.families.rst
index e209377..ce53508 100644
--- a/docs/api_ref/pywikibot.families.rst
+++ b/docs/api_ref/pywikibot.families.rst
@@ -21,11 +21,6 @@

.. automodule:: pywikibot.families.incubator_family

-pywikibot.families.lyricwiki\_family module
--------------------------------------------
-
-.. automodule:: pywikibot.families.lyricwiki_family
-
pywikibot.families.mediawiki\_family module
-------------------------------------------

diff --git a/pywikibot/families/lyricwiki_family.py b/pywikibot/families/lyricwiki_family.py
deleted file mode 100644
index 9c1ac64..0000000
--- a/pywikibot/families/lyricwiki_family.py
+++ /dev/null
@@ -1,21 +0,0 @@
-# -*- coding: utf-8 -*-
-"""Family module for LyricWiki."""
-#
-# (C) Pywikibot team, 2007-2020
-#
-# Distributed under the terms of the MIT license.
-#
-from pywikibot import family
-
-
-# The LyricWiki family
-
-# user-config.py:
-# usernames['lyricwiki']['en'] = 'user'
-class Family(family.FandomFamily):
-
- """Family class for LyricWiki."""
-
- name = 'lyricwiki'
- domain = 'lyrics.fandom.com'
- codes = ('en', 'ru')
diff --git a/tests/family_tests.py b/tests/family_tests.py
index c9ea684..8655a4f 100644
--- a/tests/family_tests.py
+++ b/tests/family_tests.py
@@ -233,7 +233,7 @@
"""Test each family builds a working regex."""
for family in pywikibot.config.family_files:
with self.subTest(family=family):
- if family in ('wowwiki', 'lyricwiki'):
+ if family == 'wowwiki':
self.skipTest(
'Family.from_url() does not work for {} (T215077)'
.format(family))
diff --git a/tests/logentries_tests.py b/tests/logentries_tests.py
index 39f31d6..942e5b0 100644
--- a/tests/logentries_tests.py
+++ b/tests/logentries_tests.py
@@ -28,9 +28,9 @@

It uses the German Wikipedia for a current representation of the
log entries and the test Wikipedia for the future representation.
- It also tests on a wiki with MW 1.19 or older to check that it can
- still read the older format. It currently uses lyricwiki which as of
- this commit uses 1.19.24.
+ It also tests on a wiki with MW 1.19 to check that it can still read
+ the older format. It currently uses wowwiki which as of this commit
+ uses 1.19.24.
"""

sites = {
@@ -45,7 +45,7 @@
'target': 'Hauptseite',
},
'old': {
- 'family': 'lyricwiki',
+ 'family': 'wowwiki',
'code': 'en',
'target': None,
}

To view, visit change 630367. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I809f5cf15938543e933d315407db11cf353ddcdf
Gerrit-Change-Number: 630367
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged