jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[R1723] Remove unecessary else after break

Change-Id: If15ef090b1b2e167a5eb98bea6e02b5d1749a50f
---
M scripts/redirect.py
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/redirect.py b/scripts/redirect.py
index e99fa33..599a983 100755
--- a/scripts/redirect.py
+++ b/scripts/redirect.py
@@ -568,15 +568,15 @@
pywikibot.output('Skipping {}.'.format(newRedir))
break
except NoPageError:
+ title = newRedir.title(as_link=True)
if self.opt.always:
pywikibot.output(
"Skipping: Redirect target {} doesn't exist."
- .format(newRedir.title(as_link=True)))
+ .format(title))
break # skip if automatic
- else:
- pywikibot.warning(
- "Redirect target {} doesn't exist."
- .format(newRedir.title(as_link=True)))
+ pywikibot.warning(
+ "Redirect target {} doesn't exist."
+ .format(title))
except ServerError:
pywikibot.output('Skipping due to server error: '
'No textarea found')

To view, visit change 688274. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: If15ef090b1b2e167a5eb98bea6e02b5d1749a50f
Gerrit-Change-Number: 688274
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged