Xqt has posted comments on this change.
Change subject: bug fix; solve bug introduced by r11524 and reported by totoazero and xqt
......................................................................
Patch Set 4:
There is a remaining bug. Try the following e.g. from idle:
>> import Wikipedia
you are asked to install patch.exe. If you decline this request you are asked a second
time. If declined a second time the script raises a fatal error while importing
beautifullsoup. Beautifullsoup is a central part if the screen scraping compat framework
and we should not prohibit using the framework for a cosmetic patch. Please give us back
that part as e.gm externals or a library script. Anyway it is not a good idea to ask for
installation (twice) and fall into a fatal error if you answer is NO. There should be
alternatives to patching the working copy (e.g. nightly dump etc.)
--
To view, visit
https://gerrit.wikimedia.org/r/76317
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30c0efab5cb2c3dfc0cb574792e7a17a5a00e2a3
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Gerrit-Reviewer: Toto Azéro <totoazero(a)yahoo.fr>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-HasComments: No