jenkins-bot merged this change.

View Change

Approvals: Zhuyifei1999: Looks good to me, approved jenkins-bot: Verified
[IMPR] Simplify creating dictionaries

Change-Id: If3f88247b2b62ca70a5d5ac02025d0c0c74c71a4
---
M scripts/casechecker.py
1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/scripts/casechecker.py b/scripts/casechecker.py
index 92aa7a6..bf2b817 100755
--- a/scripts/casechecker.py
+++ b/scripts/casechecker.py
@@ -171,20 +171,18 @@
self.titleList = [self.Page(t) for t in f]
self.failedTitles += '.failed'

+ ziplist = zip(self.localSuspects, self.latinSuspects)
self.lclToLatDict = {
- ord(self.localSuspects[i]): self.latinSuspects[i]
- for i in xrange(len(self.localSuspects))}
+ ord(local): latin for local, latin in ziplist}
self.latToLclDict = {
- ord(self.latinSuspects[i]): self.localSuspects[i]
- for i in xrange(len(self.localSuspects))}
+ ord(latin): local for local, latin in ziplist}

if self.localKeyboard is not None:
+ ziplist = zip(self.localKeyboard, self.latinKeyboard)
self.lclToLatKeybDict = {
- ord(self.localKeyboard[i]): self.latinKeyboard[i]
- for i in xrange(len(self.localKeyboard))}
+ ord(local): latin for local, latin in ziplist}
self.latToLclKeybDict = {
- ord(self.latinKeyboard[i]): self.localKeyboard[i]
- for i in xrange(len(self.localKeyboard))}
+ ord(latin): local for local, latin in ziplist}
else:
self.lclToLatKeybDict = {}
self.latToLclKeybDict = {}

To view, visit change 432773. To unsubscribe, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If3f88247b2b62ca70a5d5ac02025d0c0c74c71a4
Gerrit-Change-Number: 432773
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot <>