[Pywikibot-commits] [Gerrit] Let flake8-docstrings use multiprocessing again - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Let flake8-docstrings use multiprocessing again ...................................................................... Let flake8-docstrings use multiprocessing again flake2.2.3 turned multiprocessing on by default which caused it to stall completely under Jenkins (bug 70197). That has been worked around by turning off multiprocessing with `--jobs=1`. Pin flake8 to 2.2.5 or later and drop --jobs=1 to resume multiprocessing. Bug: 70197 Change-Id: I154f65538061730b44d455ef8e1ca94c90b4d869 --- M tox.ini 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tox.ini b/tox.ini index 0a3b48e..b422aad 100644 --- a/tox.ini +++ b/tox.ini @@ -14,18 +14,13 @@ deps = flake8 [testenv:flake8-docstrings] -commands = flake8 {posargs} --jobs=1 --ignore=D102,D103,E122,E127,E241,E265 -deps = flake8-docstrings -# Note: flake8 is run here with --jobs=1 to disable multiprocessing which stall -# the run with flake8-docstrings / pep257. -# That appeared with flake8 2.2.3 which turns multiprocessing on by default. -# -# See upstream issue: -# https://bitbucket.org/tarek/flake8/issue/167/flake8-223-stall-with-multipro… +commands = flake8 {posargs} --ignore=D102,D103,E122,E127,E241,E265 +deps = flake8>=2.2.5 + flake8-docstrings [testenv:flake8-docstrings-mandatory] # Add any new file which is pep257 compatible -commands = flake8 --jobs=1 --ignore=D102,D103,E122,E127,E241,E265 \ +commands = flake8 --ignore=D102,D103,E122,E127,E241,E265 \ ./setup.py \ ./generate_user_files.py \ ./pywikibot/__init__.py \ @@ -115,7 +110,8 @@ ./scripts/maintenance/cache.py \ ./tests/upload_tests.py -deps = flake8-docstrings +deps = flake8>=2.2.5 + flake8-docstrings [testenv:nose] setenv = PYWIKIBOT2_NO_USER_CONFIG=1 -- To view, visit https://gerrit.wikimedia.org/r/168586 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I154f65538061730b44d455ef8e1ca94c90b4d869 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Hashar &lt;hashar(a)free.fr&gt; Gerrit-Reviewer: Hashar &lt;hashar(a)free.fr&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>