jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[cleanup] cleanup scripts/unusedfiles.py

- remove preleading "u" from strings
- use single quotes for string literals
- use str.format(...) instead of modulo for changed files

Change-Id: I41e25cd244526d1b2edc5f3d89c91c512767b5dd
---
M scripts/unusedfiles.py
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/scripts/unusedfiles.py b/scripts/unusedfiles.py
index 6d30234..4465b40 100755
--- a/scripts/unusedfiles.py
+++ b/scripts/unusedfiles.py
@@ -26,8 +26,8 @@

template_to_the_image = {
'meta': '{{Orphan file}}',
- 'it': u'{{immagine orfana}}',
- 'fa': u'{{تصاویر بدون استفاده}}',
+ 'it': '{{immagine orfana}}',
+ 'fa': '{{تصاویر بدون استفاده}}',
'ur': '{{غیر مستعمل تصاویر}}',
}

@@ -57,22 +57,22 @@
self.summary = i18n.twtranslate(self.site, 'unusedfiles-comment')
if not (self.template_image and
(self.template_user or self.getOption('nouserwarning'))):
- raise pywikibot.Error(u'This script is not localized for %s site.'
- % self.site)
+ raise pywikibot.Error('This script is not localized for {0} site.'
+ .format(self.site))

def treat(self, image):
"""Process one image page."""
if not image.exists():
- pywikibot.output("File '%s' does not exist (see bug T71133)."
- % image.title())
+ pywikibot.output("File '{0}' does not exist (see bug T71133)."
+ .format(image.title()))
return
# Use fileUrl() and fileIsShared() to confirm it is local media
# rather than a local page with the same name as shared media.
if (image.fileUrl() and not image.fileIsShared() and
- u'http://' not in image.text):
+ 'http://' not in image.text):
if self.template_image in image.text:
- pywikibot.output(u"%s done already"
- % image.title(as_link=True))
+ pywikibot.output('{0} done already'
+ .format(image.title(as_link=True)))
return

self.append_text(image, '\n\n' + self.template_image)
@@ -92,7 +92,7 @@
text = page.text
else:
if page.isTalkPage():
- text = u''
+ text = ''
else:
raise pywikibot.NoPage(page)

@@ -136,5 +136,5 @@
return True


-if __name__ == "__main__":
+if __name__ == '__main__':
main()

To view, visit change 462284. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41e25cd244526d1b2edc5f3d89c91c512767b5dd
Gerrit-Change-Number: 462284
Gerrit-PatchSet: 1
Gerrit-Owner: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)