jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
Better error message handling, the error is not removed but kept

In the old implementation the error object is modified,
and so the error message is lost afterwords.

In the new implementation the message is just read
and the error object is left unchanged.

Bug: T235500
Change-Id: I6aba2fc74894b170ca5375910c208b09c03087ba
M pywikibot/data/
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pywikibot/data/ b/pywikibot/data/
index 4ae1892..5b0bb63 100644
--- a/pywikibot/data/
+++ b/pywikibot/data/
@@ -1612,7 +1612,7 @@
'actionthrottledtext', # T192912
- messages = error.pop('messages', None)
+ messages = error.get('messages')
message = None
# bug T68619; after Wikibase breaking change 1ca9cee change we have a
# list of messages

To view, visit change 559532. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aba2fc74894b170ca5375910c208b09c03087ba
Gerrit-Change-Number: 559532
Gerrit-PatchSet: 6
Gerrit-Owner: D063520 <>
Gerrit-Reviewer: D063520 <>
Gerrit-Reviewer: Xqt <>
Gerrit-Reviewer: jenkins-bot (75)
Gerrit-CC: Dvorapa <>