jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[bugfix] Additional test which assigns a text first without reading from api

Two of the additional tests are expected to fail unless a solution is
found for 645925

Patch detached from bcc30f5

Bug: T267770
Change-Id: I9511e49692cfbaeed45c1041bdfe8f32a46550ef
---
M tests/page_tests.py
1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/tests/page_tests.py b/tests/page_tests.py
index e4ef897..f7fe278 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -876,16 +876,43 @@
self.page.text = '{{in use}}'
self.assertFalse(self.page.botMayEdit())

- def test_bot_may_edit_page(self):
- """Test botMayEdit when changing content."""
+ def test_bot_may_edit_missing_page(self):
+ """Test botMayEdit for not existent page."""
self.assertTrue(self.page.botMayEdit())
self.page.text = '{{nobots}}'
self.assertTrue(self.page.botMayEdit())
+
+ def test_bot_may_edit_page_nobots(self):
+ """Test botMayEdit for existing page with nobots template."""
page = pywikibot.Page(self.site, 'Pywikibot nobots test')
self.assertFalse(page.botMayEdit())
page.text = ''
self.assertFalse(page.botMayEdit())

+ def test_bot_may_edit_page_set_text(self):
+ """Test botMayEdit for existing page when assigning text first."""
+ content = 'Does page may be changed if {{nobots}} template is found?'
+ # test the page with assigning text first
+ with self.subTest(content=content):
+ page = pywikibot.Page(self.site, 'Pywikibot nobots test')
+ page.text = content
+ self.assertFalse(page.botMayEdit())
+
+ @unittest.expectedFailure
+ def test_bot_may_edit_page_set_text_failing(self):
+ """Test botMayEdit for existing page when assigning text first."""
+ contents = (
+ 'Does page may be changed if content is not read first?',
+ 'Does page may be changed if {{bots}} template is found?',
+ )
+ # test the page with assigning text first
+ for content in contents:
+ with self.subTest(content=content):
+ page = pywikibot.Page(self.site, 'Pywikibot nobots test')
+ page.text = content
+ self.assertFalse(page.botMayEdit())
+ del page
+

class TestPageHistory(DefaultSiteTestCase):


To view, visit change 645949. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I9511e49692cfbaeed45c1041bdfe8f32a46550ef
Gerrit-Change-Number: 645949
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged