jenkins-bot submitted this change.

View Change

Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified
[fix] Do not show a warning if generator is specified later

Bug: T310418
Change-Id: I4c2958fc0b43de5dbe1e9deb57ce770f2d421fe8
---
M scripts/harvest_template.py
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py
index f6b778b..04cd5df 100755
--- a/scripts/harvest_template.py
+++ b/scripts/harvest_template.py
@@ -423,10 +423,9 @@
'Please specify either -template or -transcludes argument')
return

- generator = gen.getCombinedGenerator(preload=True)
- if not generator:
+ if not gen.gens:
gen.handle_arg('-transcludes:' + template_title)
- generator = gen.getCombinedGenerator(preload=True)
+ generator = gen.getCombinedGenerator(preload=True)

bot = HarvestRobot(template_title, fields, generator=generator, **options)
bot.run()

To view, visit change 804699. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I4c2958fc0b43de5dbe1e9deb57ce770f2d421fe8
Gerrit-Change-Number: 804699
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia@gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged