jenkins-bot merged this change.

View Change

Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
[IMPR] use ShowingListOption with pagegenerators.py

Change-Id: I3c6019845569819b275532a958bd4f7b33f4652d
---
M pywikibot/pagegenerators.py
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 25db7bb..638bb7b 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -14,7 +14,7 @@
&params;
"""
#
-# (C) Pywikibot team, 2008-2019
+# (C) Pywikibot team, 2008-2020
#
# Distributed under the terms of the MIT license.
#
@@ -48,7 +48,7 @@
)

from pywikibot import date, config, i18n, xmlreader
-from pywikibot.bot import ListOption
+from pywikibot.bot import ShowingListOption
from pywikibot.comms import http
from pywikibot.exceptions import (
ArgumentDeprecationWarning,
@@ -804,12 +804,8 @@
pnames = self.site.get_property_names()
# also use the default by <enter> key
if value in '?' or value not in pnames:
- for i, item in enumerate(pnames, start=1):
- pywikibot.output(
- '{0:{1}}: {2}'.format(i, len(str(len(pnames))),
- item))
prefix, value = pywikibot.input_choice(
- question, ListOption(self.site.get_property_names()))
+ question, ShowingListOption(pnames))
return page_with_property_generator(value, site=self.site)

def _handle_usercontribs(self, value):

To view, visit change 439481. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c6019845569819b275532a958bd4f7b33f4652d
Gerrit-Change-Number: 439481
Gerrit-PatchSet: 8
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot (75)