jenkins-bot merged this change.

View Change

Approvals: D3r1ck01: Looks good to me, but someone else must approve Dvorapa: Looks good to me, approved jenkins-bot: Verified
[cleanup] Remove unused deprecated filterParents function

Patch 3 detached from I28d72f2

Bug: T195079
Bug: T78462
Change-Id: Iab2ddc3d1c764b14f3bf4109547061d2f6c4f478
---
M scripts/imagerecat.py
1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/scripts/imagerecat.py b/scripts/imagerecat.py
index d4db6aa..824b163 100755
--- a/scripts/imagerecat.py
+++ b/scripts/imagerecat.py
@@ -22,7 +22,6 @@
import pywikibot

from pywikibot import pagegenerators, textlib
-from pywikibot.tools import deprecated


category_blacklist = []
@@ -131,9 +130,7 @@

First make a list of any ...by country categories and try to find some
countries. If a by country category has a subcategoy containing one of the
- countries found, add it. The ...by country categories remain in the set and
- should be filtered out by filterParents.
-
+ countries found, add it. The ...by country categories remain in the set.
"""
result = categories
listByCountry = []
@@ -159,18 +156,6 @@
return list(set(result))


-@deprecated(since='20180120')
-def filterParents(categories):
- """
- Remove all parent categories from the set to prevent overcategorization.
-
- DEPRECATED: Toolserver script isn't available anymore (T78462).
- This method is kept for compatibility and may be restored sometime by a new
- implementation.
- """
- return categories
-
-
def saveImagePage(imagepage, newcats):
"""Remove the old categories and add the new categories to the image."""
newtext = textlib.removeCategoryLinks(imagepage.text, imagepage.site)

To view, visit change 553843. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab2ddc3d1c764b14f3bf4109547061d2f6c4f478
Gerrit-Change-Number: 553843
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)