jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[IMPR] only add bot option generator if the bot class have it already

Change-Id: I298ff92cda2803d38e44480f5122303215e4f9bb
---
M pywikibot/bot.py
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index a8945ea..8270f64 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -1173,13 +1173,17 @@
_current_page = None

def __init__(self, **kwargs):
- """
- Only accept options defined in available_options.
+ """Only accept 'generator' and options defined in available_options.

@param kwargs: bot options
+ @keyword generator: a generator processed by run method
"""
if 'generator' in kwargs:
- self.generator = kwargs.pop('generator')
+ if hasattr(self, 'generator'):
+ pywikibot.warn('{} has a generator already. Ignoring argument.'
+ .format(self.__class__.__name__))
+ else:
+ self.generator = kwargs.pop('generator')

super().__init__(**kwargs)


To view, visit change 668004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I298ff92cda2803d38e44480f5122303215e4f9bb
Gerrit-Change-Number: 668004
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: DannyS712 <DannyS712.enwiki@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged