jenkins-bot submitted this change.

View Change

Revert "[tests] mark tests as expecte4dFailure until underlying issue is solved"

This reverts commit b584e3b2767b181cbf6c7a7c1e2b88e8e94826ee.

Reason for revert: solved upstream:
https://www.wikidata.org/w/index.php?title=Q668&diff=2193039158&oldid=2192338581

Bug: T368879
Change-Id: I28e277e8b7f869d4ccac3112cbaa210ed2662546
---
M tests/pagegenerators_tests.py
1 file changed, 0 insertions(+), 7 deletions(-)

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 786908b..ecb4946 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -839,7 +839,6 @@
         site = self.get_site()
         return pywikibot.Page(site, 'Q37470')
 
-    @unittest.expectedFailure  # T368879
     def test_valid_qualifiers(self):
         """Test ItemClaimFilterPageGenerator using valid qualifiers."""
         qualifiers = {
@@ -850,7 +849,6 @@
         self._simple_claim_test('P463', self._get_council_page(), qualifiers,
                                 True)
 
-    @unittest.expectedFailure  # T368879
     def test_invalid_qualifiers(self):
         """Test ItemClaimFilterPageGenerator with invalid qualifiers."""
         qualifiers = {
@@ -861,7 +859,6 @@
         self._simple_claim_test('P463', self._get_council_page(), qualifiers,
                                 False)
 
-    @unittest.expectedFailure  # T368879
     def test_nonexisting_qualifiers(self):
         """
         Test ItemClaimFilterPageGenerator on sample page.
@@ -877,7 +874,6 @@
         self._simple_claim_test('P463', self._get_council_page(), qualifiers,
                                 False)
 
-    @unittest.expectedFailure  # T368879
     def test_no_qualifiers(self):
         """Test ItemClaimFilterPageGenerator without qualifiers."""
         self._simple_claim_test('P474', '+91', None, True)
@@ -885,13 +881,11 @@
         self._simple_claim_test('P1334', '28,97.4,0.1', None, True)
         self._simple_claim_test('P1334', '28,96,0.01', None, False)
 
-    @unittest.expectedFailure  # T368879
     def test_negative_filter(self):
         """Test negative ItemClaimFilterPageGenerator."""
         self._simple_claim_test('P463', 'Q37470', None, False, True)
         self._simple_claim_test('P463', 'Q37471', None, True, True)
 
-    @unittest.expectedFailure  # T368879
     def test_item_from_page(self):
         """Test ItemPage can be obtained form Page."""
         site = pywikibot.Site('en', 'wikipedia')
@@ -1503,7 +1497,6 @@
         self.assertIsNotNone(gen)
         self.assertIsEmpty(set(gen))
 
-    @unittest.expectedFailure  # T368879
     def test_onlyif_qualifiers(self):
         """Test -onlyif with qualifiers."""
         gf = pagegenerators.GeneratorFactory(site=self.site)

To view, visit change 1051137. To unsubscribe, or for help writing mail filters, visit settings.