jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
page.py: Fix param info in FileInfo.__init__ and get_file_url docstrings

Fix the param names in get_file_url.
FileInfo did not have any param named `page`.

Change-Id: I8b6a8da4f58a008c2b87af07270da7ae8737967e
---
M pywikibot/page.py
1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/pywikibot/page.py b/pywikibot/page.py
index 126fb95..dd4f49a 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -2500,13 +2500,11 @@

Parameters validation and error handling left to the API call.

- @param width: see iiurlwidth in [1]
- @param height: see iiurlheigth in [1]
- @param param: see iiurlparam in [1]
-
+ @param url_width: see iiurlwidth in [1]
+ @param url_height: see iiurlheigth in [1]
+ @param url_param: see iiurlparam in [1]
@return: latest file url or thumburl
@rtype: unicode
-
"""
# Plain url is requested.
if url_width is None and url_height is None and url_param is None:
@@ -5413,12 +5411,7 @@
"""

def __init__(self, file_revision):
- """
- Create class with the dictionary returned by site.loadimageinfo().
-
- @param page: FilePage containing the image.
- @type page: FilePage object
- """
+ """Initiate the class using the dict from L{APISite.loadimageinfo}."""
self.__dict__.update(file_revision)
self.timestamp = pywikibot.Timestamp.fromISOformat(self.timestamp)


To view, visit change 459772. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b6a8da4f58a008c2b87af07270da7ae8737967e
Gerrit-Change-Number: 459772
Gerrit-PatchSet: 1
Gerrit-Owner: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)