jenkins-bot submitted this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[IMPR]: make IndexPage more robust when getting links in Page ns

site.pagelinks() sometimes might miss some links, due to reasons outside
pywikibot.
Until the root cause is clarified, make it more robust, at the expense
of one extra query.

Bug: T307280
Change-Id: I981be2346ad0f4f4601dc07cc3f43b9987a054a0
---
M pywikibot/proofreadpage.py
1 file changed, 3 insertions(+), 0 deletions(-)

diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py
index 6b9914c..9a6267c 100644
--- a/pywikibot/proofreadpage.py
+++ b/pywikibot/proofreadpage.py
@@ -826,6 +826,9 @@

self._all_page_links = set(
self.site.pagelinks(self, namespaces=site.proofread_page_ns))
+ # bug T307280
+ self._all_page_links |= set(
+ self.site.pagetemplates(self, namespaces=site.proofread_page_ns))

self._cached = False


To view, visit change 787876. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I981be2346ad0f4f4601dc07cc3f43b9987a054a0
Gerrit-Change-Number: 787876
Gerrit-PatchSet: 1
Gerrit-Owner: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged