jenkins-bot submitted this change.

View Change

Approvals: 4shadoww: Looks good to me, but someone else must approve JJMC89: Looks good to me, approved jenkins-bot: Verified
[bugfix] PageArchiver.maxsize must be defined before load_config()

Bug: T277547
Change-Id: I7ae69274aa4656a7ab494065531344b85ae196d0
---
M scripts/archivebot.py
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/scripts/archivebot.py b/scripts/archivebot.py
index 2fe7542..2e02e3c 100755
--- a/scripts/archivebot.py
+++ b/scripts/archivebot.py
@@ -524,6 +524,14 @@
self.site = page.site
self.tpl = template
self.timestripper = TimeStripper(site=self.site)
+
+ # read maxarticlesize
+ try:
+ # keep a gap of 1 KB not to block later changes
+ self.maxsize = self.site.siteinfo['maxarticlesize'] - 1024
+ except KeyError: # mw < 1.28
+ self.maxsize = 2096128 # 2 MB - 1 KB gap
+
self.page = DiscussionPage(page, self)
self.load_config()
self.comment_params = {
@@ -536,13 +544,6 @@
for n, (long, short) in enumerate(self.site.months_names, start=1):
self.month_num2orig_names[n] = {'long': long, 'short': short}

- # read maxarticlesize
- try:
- # keep a gap of 1 KB not to block later changes
- self.maxsize = self.site.siteinfo['maxarticlesize'] - 1024
- except KeyError: # mw < 1.28
- self.maxsize = 2096128 # 2 MB - 1 KB gap
-
def get_attr(self, attr, default='') -> Any:
"""Get an archiver attribute."""
return self.attributes.get(attr, [default])[0]

To view, visit change 673020. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I7ae69274aa4656a7ab494065531344b85ae196d0
Gerrit-Change-Number: 673020
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: 4shadoww <4shadoww0@gmail.com>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki@aol.com>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia@gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged