jenkins-bot has submitted this change and it was merged.
Change subject: Fix test_preload_langlinks_count
......................................................................
Fix test_preload_langlinks_count
listify the generator and compare its length with preloaded items
Change-Id: Ic763d2d60a502d58c056df0bf209a97805798832
---
M tests/site_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
XZise: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index d0f85d5..6ae8a6d 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1993,7 +1993,7 @@
self.assertFalse(hasattr(page, '_pageprops'))
count += 1
- self.assertEqual(len(links), count)
+ self.assertEqual(len(list(links)), count)
def _test_preload_langlinks_long(self):
"""Test preloading continuation works."""
--
To view, visit
https://gerrit.wikimedia.org/r/187682
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic763d2d60a502d58c056df0bf209a97805798832
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>