jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
pagegenerators_tests: amend test_QualityFilterPageGenerator

Remove meaningless code in test_QualityFilterPageGenerator()
and add instead relevant tests:
- NamespaceFilterPageGenerator changed to QualityFilterPageGenerator
- add check when quality is 4

Change-Id: I66e577362b8ddb3d30f29a9346e8d2d567b920df
---
M tests/pagegenerators_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 4b43dbc..dc033dd 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -267,7 +267,8 @@
gen = pagegenerators.QualityFilterPageGenerator(gen, [0])
self.assertLength(tuple(gen), 7)
gen = pagegenerators.PagesFromTitlesGenerator(self.titles, site)
- gen = pagegenerators.NamespaceFilterPageGenerator(gen, [4])
+ gen = pagegenerators.QualityFilterPageGenerator(gen, [4])
+ self.assertLength(tuple(gen), 3)
gen = pagegenerators.PagesFromTitlesGenerator(self.titles, site)
self.assertLength(tuple(gen), 10)


To view, visit change 517932. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e577362b8ddb3d30f29a9346e8d2d567b920df
Gerrit-Change-Number: 517932
Gerrit-PatchSet: 1
Gerrit-Owner: Mpaa <mpaa.wiki@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)