jenkins-bot submitted this change.

View Change

Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified
[tests] remove isort from tests

isort tests looks to heavy and demands a wrong sorting order
https://integration.wikimedia.org/ci/job/pywikibot-core-tox-docker/15376/console
(probably uppercase first)

Do not include isort to flake8 tests but add it to dev-requirements.txt
to be runned manually.

See also T132122

Bug: T166950
Change-Id: I8f0b16f07151eb0fc1efab341d6c773f8ed57351
---
M dev-requirements.txt
M setup.py
2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev-requirements.txt b/dev-requirements.txt
index 7323cec..777353a 100644
--- a/dev-requirements.txt
+++ b/dev-requirements.txt
@@ -16,6 +16,7 @@
pyflakes>=2.1.0
flake8>=3.7.5
flake8-docstrings>=0.2.6
+flake8-isort;python_version>=3.6
flake8-mock>=0.3
codecov
coverage
diff --git a/setup.py b/setup.py
index 4abb54d..4e352ed 100644
--- a/setup.py
+++ b/setup.py
@@ -81,7 +81,6 @@
'flake8-comprehensions>=2.2.0',
'flake8-docstrings>=1.3.1',
'flake8-future-import',
- 'flake8-isort;python_version>="3.6"',
'flake8-mock>=0.3',
'flake8-print>=2.0.1',
'flake8-quotes>=2.0.1',

To view, visit change 684017. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I8f0b16f07151eb0fc1efab341d6c773f8ed57351
Gerrit-Change-Number: 684017
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia@gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged