jenkins-bot merged this change.

View Change

Approvals: Framawiki: Looks good to me, approved jenkins-bot: Verified
[IMPR] Simplify tuple expression

also use private function _make_parameter directly

Change-Id: I99f03f3c1f329b03838fb3faad2272da7bebe959
---
M pywikibot/date.py
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/pywikibot/date.py b/pywikibot/date.py
index b2da643..3f3a8c1 100644
--- a/pywikibot/date.py
+++ b/pywikibot/date.py
@@ -465,23 +465,20 @@

params = encf(value)

- # name 'MakeParameter' kept to avoid breaking blame below
- MakeParameter = _make_parameter
-
if type(params) in _listTypes:
assert len(params) == len(decoders), (
'parameter count ({0}) does not match decoder count ({1})'
.format(len(params), len(decoders)))
# convert integer parameters into their textual representation
- params = [MakeParameter(decoders[i], param)
- for i, param in enumerate(params)]
- return strPattern % tuple(params)
+ params = tuple(_make_parameter(decoders[i], param)
+ for i, param in enumerate(params))
+ return strPattern % params
else:
assert len(decoders) == 1, (
'A single parameter does not match {0} decoders.'
.format(len(decoders)))
# convert integer parameter into its textual representation
- return strPattern % MakeParameter(decoders[0], params)
+ return strPattern % _make_parameter(decoders[0], params)


def _make_parameter(decoder, param):

To view, visit change 511680. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99f03f3c1f329b03838fb3faad2272da7bebe959
Gerrit-Change-Number: 511680
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Framawiki <framawiki@tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: jenkins-bot (75)